updated stuff

2026-05-09 20:37:27 +01:00
parent 3c5bbaea0b
commit c53db55209
1 changed files with 70 additions and 36 deletions
@@ -179,58 +179,92 @@ export function buildProxyFiberHookScript(): string {
  }
  // ── React DevTools global hook ────────────────────────────────────────────
-  // Strategy: completely replace window.__REACT_DEVTOOLS_GLOBAL_HOOK__ with a
+  // Two-layer bulletproof strategy:
  // fresh, fully-specified hook object. This eliminates all timing hazards:
  //
-  //  1. Chrome DevTools extension injects at document_start (before HTML is
+  // LAYER 1 — Lock the global: replace window.__REACT_DEVTOOLS_GLOBAL_HOOK__
-  //     parsed) and installs a stub where hook.inject = undefined. Patching
+  //   with our fresh hook, then make the property non-writable so neither the
-  //     that stub still leaves React Refresh free to capture undefined before
+  //   Chrome DevTools extension (which runs at document_start and may
-  //     our patch runs. Replacing the object entirely avoids the problem.
+  //   re-initialize) nor any webpack module can swap it out again.
  //
-  //  2. React Refresh (Next.js dev) runs after our <script> (which is at the
+  // LAYER 2 — Lock inject via getter/setter: define hook.inject as an accessor
-  //     very top of <head>). It captures hook.inject as oldInject. Because
+  //   property. GET always returns a working implementation (_omInjectCurrent).
-  //     OUR inject is a proper function that never throws, React Refresh's
+  //   SET intercepts React Refresh's attempt to wrap inject and re-wraps the
-  //     wrapper works, and React successfully sets injectedHook.
+  //   wrapper with a try-catch fallback, so even if React Refresh captured
-  //
+  //   oldInject=undefined from an earlier stub and its wrapper throws at call
-  //  3. All methods React 19 and React Refresh might call are present as
+  //   time, we catch the error and fall back to our own ID allocation.
-  //     no-ops (checkDCE, onScheduleFiberRoot, onPostCommitFiberRoot, etc.)
+  //   This handles EVERY timing scenario without relying on script order.
  //     so nothing blows up on first access.
  //
  //  4. isDisabled=false (not _isDisabled): React Refresh reads isDisabled.
  //     If truthy, React Refresh skips wrapping inject entirely and React
  //     never gets tracked.
  // Save onCommitFiberRoot from any pre-existing hook (e.g. DevTools extension).
  var _existingHook = window.__REACT_DEVTOOLS_GLOBAL_HOOK__;
  var _prevCommit   = (_existingHook && typeof _existingHook.onCommitFiberRoot === 'function')
    ? _existingHook.onCommitFiberRoot : null;
  var _omNextId = 0;
  // Base inject implementation — always safe, never throws.
  var _omInjectCurrent = function(renderer) {
    try {
      var id = ++_omNextId;
      hook.renderers.set(id, renderer);
      console.log(OM_TAG, 'React registered via inject(), rendererId=' + id);
      return id;
    } catch(e) {
      return ++_omNextId;
    }
  };
  var hook = {
    renderers:             new Map(),
    supportsFiber:         true,
-    isDisabled:            false,        // React Refresh reads this; must be false
+    isDisabled:            false,    // React Refresh checks this; must be false
    checkDCE:              function() {},
    onScheduleFiberRoot:   function() {},
    onCommitFiberUnmount:  function() {},
    onPostCommitFiberRoot: function() {},
-    inject: function(renderer) {
+    onCommitFiberRoot:     null,     // assigned below
-      // This function MUST NEVER THROW. React 19 wraps the hook.inject() call
+    // inject is NOT in the literal — it is defined as a getter/setter below.
      // in a try/catch and silently discards the hook if it throws, leaving
      // injectedHook unset so onCommitFiberRoot is never called.
      try {
        var id = ++_omNextId;
        hook.renderers.set(id, renderer);
        console.log(OM_TAG, 'React registered via inject(), rendererId=' + id);
        return id;
      } catch(e) {
        console.error(OM_TAG, 'inject() threw unexpectedly:', e);
        return ++_omNextId; // still return a valid ID
      }
    },
    onCommitFiberRoot: null, // assigned below after the object is built
  };
-  window.__REACT_DEVTOOLS_GLOBAL_HOOK__ = hook;
+
  // Layer 2: protect inject with an accessor property.
  // React Refresh does: var oldInject = hook.inject; hook.inject = wrapper(oldInject);
  // Our getter ensures oldInject is NEVER undefined regardless of timing.
  // Our setter wraps whatever React Refresh installs with a try-catch so that
  // even a broken wrapper (where oldInject was captured as undefined from an
  // earlier DevTools stub) falls back gracefully.
  Object.defineProperty(hook, 'inject', {
    configurable: true,
    enumerable:   true,
    get: function() { return _omInjectCurrent; },
    set: function(fn) {
      if (typeof fn !== 'function') return;
      var wrapped = fn;
      _omInjectCurrent = function(renderer) {
        try {
          return wrapped.apply(this, arguments);
        } catch(e) {
          // React Refresh's wrapper tried to call an undefined oldInject.
          // Fall back to direct ID allocation.
          console.log(OM_TAG, 'inject() fallback after wrapper error, id=' + (_omNextId + 1));
          var id = ++_omNextId;
          hook.renderers.set(id, renderer);
          return id;
        }
      };
    },
  });
  // Layer 1: lock the global so nothing can replace our hook after this point.
  try {
    Object.defineProperty(window, '__REACT_DEVTOOLS_GLOBAL_HOOK__', {
      configurable: false,
      enumerable:   true,
      writable:     false,
      value:        hook,
    });
  } catch(e) {
    // Property is already non-configurable (DevTools extension locked it first).
    // Simple assignment is a best-effort fallback.
    window.__REACT_DEVTOOLS_GLOBAL_HOOK__ = hook;
  }
  hook.onCommitFiberRoot = function(rendererId, root, priorityLevel, didError) {
    console.log(OM_TAG, 'onCommitFiberRoot fired, rendererId=' + rendererId);